Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flight] erroring after abort should not result in unhandled rejection #30675

Merged
merged 1 commit into from
Aug 13, 2024

Commits on Aug 13, 2024

  1. [Flight] erroring after abort should not result in unhandled rejection

    When I implemented the ability to abort synchronoulsy in flight I made it possible for erroring async server components to cause an unhandled rejection error. In the current implementation if you abort during the synchronous phase of a Function Component and then throw an error in the synchronous phase React will not attach any promise handlers because it short circuits the thenable treatment and throws an AbortSigil instead. This change updates the rendering logic to ignore the rejecting component.
    gnoff committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    e50f369 View commit details
    Browse the repository at this point in the history