Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools] Support Server Components in Tree #30684

Merged
merged 8 commits into from
Aug 14, 2024

Commits on Aug 14, 2024

  1. Mount virtual instances

    sebmarkbage committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    a99a5f5 View commit details
    Browse the repository at this point in the history
  2. Unmount virtual instances

    Since the same instance can have multiple child fibers, we need a ref count
    to know when it's safe to delete.
    sebmarkbage committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    5402eee View commit details
    Browse the repository at this point in the history
  3. Update virtual instances

    sebmarkbage committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    9356b03 View commit details
    Browse the repository at this point in the history
  4. Handle reparenting

    When a fiber moves from one virtual parent to another, we unmount the
    previous one and mount a new FiberInstance. This means that it is now
    possible for a Fiber to be associated with more than one FiberInstance
    at least temporarily.
    
    It also means we can't assume that just because an instance has an alternate
    that we have already mounted it because it might have been deleted and
    recreated.
    
    This makes more sense if we reconciled from the previous parent instance than
    the fiberToFiberInstance map.
    sebmarkbage committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    ec79b8e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    31ae174 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    082418e View commit details
    Browse the repository at this point in the history
  7. Test tree

    sebmarkbage committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    4d1de50 View commit details
    Browse the repository at this point in the history
  8. Update copypasta error message.

    Co-authored-by: Ruslan Lesiutin <rdlesyutin@gmail.com>
    sebmarkbage and hoxyq authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    f4e101b View commit details
    Browse the repository at this point in the history