Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler] Add enablePropagateDepsInHIR flag #30893

Merged
merged 1 commit into from
Sep 6, 2024
Merged

[compiler] Add enablePropagateDepsInHIR flag #30893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions compiler/packages/babel-plugin-react-compiler/src/HIR/Environment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,8 @@ const EnvironmentConfigSchema = z.object({
*/
enableUseTypeAnnotations: z.boolean().default(false),

enablePropagateDepsInHIR: z.boolean().default(true),

/**
* Enables inference of optional dependency chains. Without this flag
* a property chain such as `props?.items?.foo` will infer as a dep on
Expand Down
4 changes: 2 additions & 2 deletions ...rc/__tests__/fixtures/compiler/optional-member-expression-as-memo-dep.expect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
## Input

```javascript
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m assuming these are the only fixtures where output changes so you’re preemptively disabling to get zero output difference on the next pr? Which makes sense

function Component(props) {
const data = useMemo(() => {
return props?.items.edges?.nodes.map();
Expand All @@ -15,7 +15,7 @@ function Component(props) {
## Code

```javascript
import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
function Component(props) {
const $ = _c(4);

Expand Down
2 changes: 1 addition & 1 deletion ...-react-compiler/src/__tests__/fixtures/compiler/optional-member-expression-as-memo-dep.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
function Component(props) {
const data = useMemo(() => {
return props?.items.edges?.nodes.map();
Expand Down
4 changes: 2 additions & 2 deletions ...compiler/optional-member-expression-inverted-optionals-parallel-paths.expect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
## Input

```javascript
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
import {ValidateMemoization} from 'shared-runtime';
function Component(props) {
const data = useMemo(() => {
Expand All @@ -19,7 +19,7 @@ function Component(props) {
## Code

```javascript
import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
import { ValidateMemoization } from "shared-runtime";
function Component(props) {
const $ = _c(2);
Expand Down
2 changes: 1 addition & 1 deletion ...tests__/fixtures/compiler/optional-member-expression-inverted-optionals-parallel-paths.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
import {ValidateMemoization} from 'shared-runtime';
function Component(props) {
const data = useMemo(() => {
Expand Down
4 changes: 2 additions & 2 deletions ...ixtures/compiler/optional-member-expression-single-with-unconditional.expect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
## Input

```javascript
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
import {ValidateMemoization} from 'shared-runtime';
function Component(props) {
const data = useMemo(() => {
Expand All @@ -19,7 +19,7 @@ function Component(props) {
## Code

```javascript
import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
import { ValidateMemoization } from "shared-runtime";
function Component(props) {
const $ = _c(7);
Expand Down
2 changes: 1 addition & 1 deletion ...r/src/__tests__/fixtures/compiler/optional-member-expression-single-with-unconditional.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
import {ValidateMemoization} from 'shared-runtime';
function Component(props) {
const data = useMemo(() => {
Expand Down
4 changes: 2 additions & 2 deletions ...ler/src/__tests__/fixtures/compiler/optional-member-expression-single.expect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
## Input

```javascript
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
import {ValidateMemoization} from 'shared-runtime';
function Component(props) {
const data = useMemo(() => {
Expand All @@ -18,7 +18,7 @@ function Component(props) {
## Code

```javascript
import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
import { ValidateMemoization } from "shared-runtime";
function Component(props) {
const $ = _c(7);
Expand Down
2 changes: 1 addition & 1 deletion ...lugin-react-compiler/src/__tests__/fixtures/compiler/optional-member-expression-single.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
import {ValidateMemoization} from 'shared-runtime';
function Component(props) {
const data = useMemo(() => {
Expand Down
4 changes: 2 additions & 2 deletions ...ixtures/compiler/optional-member-expression-with-conditional-optional.expect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
## Input

```javascript
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
import {ValidateMemoization} from 'shared-runtime';
function Component(props) {
const data = useMemo(() => {
Expand All @@ -23,7 +23,7 @@ function Component(props) {
## Code

```javascript
import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
import { ValidateMemoization } from "shared-runtime";
function Component(props) {
const $ = _c(9);
Expand Down
2 changes: 1 addition & 1 deletion ...r/src/__tests__/fixtures/compiler/optional-member-expression-with-conditional-optional.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
import {ValidateMemoization} from 'shared-runtime';
function Component(props) {
const data = useMemo(() => {
Expand Down
4 changes: 2 additions & 2 deletions ...tests__/fixtures/compiler/optional-member-expression-with-conditional.expect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
## Input

```javascript
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
import {ValidateMemoization} from 'shared-runtime';
function Component(props) {
const data = useMemo(() => {
Expand All @@ -23,7 +23,7 @@ function Component(props) {
## Code

```javascript
import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
import { ValidateMemoization } from "shared-runtime";
function Component(props) {
const $ = _c(9);
Expand Down
2 changes: 1 addition & 1 deletion ...t-compiler/src/__tests__/fixtures/compiler/optional-member-expression-with-conditional.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
import {ValidateMemoization} from 'shared-runtime';
function Component(props) {
const data = useMemo(() => {
Expand Down