Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added comments to clarify key handling in jsx and createElement #30964

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ravi80595
Copy link

Summary

Added comments to clarify the handling of key in jsx and createElement.

  • Explained why key can be reused in jsx since it always passes a new object.
  • Noted that createElement might reuse the same props object, so assumptions about key reuse cannot be made.
  • Updated comments to explain the current behavior of spreading keys causing warnings and noted future plans to retain spread keys while maintaining warnings.

How did you test this change?

  • Code Review: Verified that the comments correctly describe the behavior by reviewing the relevant code sections.
  • Testing: Ensured no functional changes were made by running the existing test suite and confirmed all tests passed.
  • Alignment: Checked that the comments are consistent with the current and planned behavior for handling key.

Copy link

vercel bot commented Sep 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2024 2:45am

@facebook-github-bot
Copy link

Hi @Ravi80595!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants