[Fiber] Color Performance Track Entries by Self Time #30984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: e1c2090...0d782cc Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sebmarkbage
commented
Sep 17, 2024
| @@ -54,6 +54,44 @@ export function logComponentRender( | |||
| return; | |||
| } | |||
| if (supportsUserTiming) { | |||
| let selfTime: number = (fiber.actualDuration: any); | |||
| for (let child = fiber.child; child !== null; child = child.sibling) { | |||
| selfTime -= (child.actualDuration: any); | |||
There was a problem hiding this comment.
I don't love this loop for every rendered component. We could maybe change how we keep track of this but that might require another field. We could also maybe keep track of this by reusing the commit loop.
hoxyq
approved these changes
Sep 17, 2024
sebmarkbage
force-pushed
the
performancemeasure4
branch
from
f4900e9 to
d771ad9
Compare
sebmarkbage
force-pushed
the
performancemeasure4
branch
from
d771ad9 to
540bff7
Compare
sebmarkbage
force-pushed
the
performancemeasure4
branch
from
540bff7 to
665efad
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
Stacked on #30983. This colors each component entry by its self time from light to dark depending on how long it took. If it took longer than a cut off we color it red (the error color). <img width="435" alt="Screenshot 2024-09-16 at 11 48 15 PM" src="https://github.com/user-attachments/assets/5d0bda83-6205-40e9-bec1-b81db2d48b2d"> DiffTrain build for [8dfbd16](8dfbd16)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #30983.
This colors each component entry by its self time from light to dark depending on how long it took. If it took longer than a cut off we color it red (the error color).