[compiler][playground] create playground API in pipeline, and allow spaces in pass names #30988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…paces in pass names Summary: 1. Minor refactor to provide a stable API for calling the compiler from the playground 2. Allows spaces in pass names without breaking the appearance of the playground by replacing spaces with in pass tabs [ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mvitousek
added a commit
that referenced
this pull request
Sep 17, 2024
…paces in pass names Summary: 1. Minor refactor to provide a stable API for calling the compiler from the playground 2. Allows spaces in pass names without breaking the appearance of the playground by replacing spaces with in pass tabs ghstack-source-id: 12a43ad86c16c0e21f3e6b4086d531cdefd893eb Pull Request resolved: #30988
Comment on lines
+558
to
+567
| export function* runPlayground( | ||
| func: NodePath< | ||
| t.FunctionDeclaration | t.ArrowFunctionExpression | t.FunctionExpression | ||
| >, | ||
| config: EnvironmentConfig, | ||
| fnType: ReactFunctionType, | ||
| ): Generator<CompilerPipelineValue, CodegenFunction> { | ||
| const ast = yield* run(func, config, fnType, '_c', null, null, null); | ||
| return ast; | ||
| } |
There was a problem hiding this comment.
how is this different from run?
josephsavona
approved these changes
Sep 17, 2024
mvitousek
added a commit
that referenced
this pull request
Sep 17, 2024
…paces in pass names Summary: 1. Minor refactor to provide a stable API for calling the compiler from the playground 2. Allows spaces in pass names without breaking the appearance of the playground by replacing spaces with in pass tabs ghstack-source-id: 12a43ad86c16c0e21f3e6b4086d531cdefd893eb Pull Request resolved: #30988
github-actions bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
…paces in pass names Summary: 1. Minor refactor to provide a stable API for calling the compiler from the playground 2. Allows spaces in pass names without breaking the appearance of the playground by replacing spaces with in pass tabs ghstack-source-id: 12a43ad86c16c0e21f3e6b4086d531cdefd893eb Pull Request resolved: #30988 DiffTrain build for [7b56a54](7b56a54)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: