Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Add test for nested render baseQueue bug #30990

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rickhanlonii
Copy link
Member

Found a bug where if the baseQueue is not empty, and we do a render-phase update, we won't update the base state within the same sync render (like for a layout effect update, but probably also for passive effects for discrete events).

Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 6:33pm

@react-sizebot
Copy link

react-sizebot commented Sep 17, 2024

Comparing: 7b56a54...ce80bde

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 509.35 kB 509.35 kB = 91.10 kB 91.10 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 514.28 kB 514.28 kB = 91.82 kB 91.82 kB
facebook-www/ReactDOM-prod.classic.js = 604.86 kB 604.90 kB = 106.86 kB 106.87 kB
facebook-www/ReactDOM-prod.modern.js = 581.13 kB 581.13 kB = 103.01 kB 103.01 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 5700442

@josephsavona
Copy link
Contributor

Nice job distilling the repro and finding the root cause! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants