Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime_commit_artifacts workflow #31028

Merged
merged 7 commits into from
Sep 23, 2024
Merged

Conversation

poteto
Copy link
Member

@poteto poteto commented Sep 23, 2024

Stack from ghstack (oldest at bottom):

I messed up the yml syntax and also realized that our script doesn't
currently handle renames or deletes, so I fixed that

[ghstack-poisoned]
Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 9:35pm

poteto added a commit that referenced this pull request Sep 23, 2024
ghstack-source-id: cb91cb86f65047e913e6c8993dd9dcaba69b7dec
Pull Request resolved: #31028
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 23, 2024
@react-sizebot
Copy link

react-sizebot commented Sep 23, 2024

Comparing: 5b19dc0...4963983

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.11% 1.82 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 509.10 kB 509.10 kB = 91.06 kB 91.06 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.11% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 514.04 kB 514.04 kB = 91.78 kB 91.78 kB
facebook-www/ReactDOM-prod.classic.js = 603.53 kB 603.53 kB = 106.78 kB 106.78 kB
facebook-www/ReactDOM-prod.modern.js = 579.76 kB 579.76 kB = 102.88 kB 102.88 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 2e1d261

[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 23, 2024
ghstack-source-id: b426687fb906abf89d14aa22a2d10d4f10f86b5d
Pull Request resolved: #31028
[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 23, 2024
ghstack-source-id: e5cc566c5ef1093e0f1dc607b96809b696007f28
Pull Request resolved: #31028
[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 23, 2024
ghstack-source-id: 2d17fe255743b7157896f2b28af4f75f36bfd86c
Pull Request resolved: #31028
[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 23, 2024
ghstack-source-id: 90d6454286616d1689021aa34b850857582fb45a
Pull Request resolved: #31028
poteto added a commit that referenced this pull request Sep 23, 2024
ghstack-source-id: 90d6454286616d1689021aa34b850857582fb45a
Pull Request resolved: #31028
[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 23, 2024
ghstack-source-id: 83bd7ea4cd7c1446d8f031dc9ecdd6663e27c9c4
Pull Request resolved: #31028
[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 23, 2024
ghstack-source-id: 7d481a951abaabd1a2985c8959d8acb7103ed12e
Pull Request resolved: #31028
@poteto poteto changed the title Fix yml Fix runtime_commit_artifacts workflow Sep 23, 2024
poteto added a commit that referenced this pull request Sep 23, 2024
I messed up the yml syntax and also realized that our script doesn't
currently handle renames or deletes, so I fixed that

ghstack-source-id: 7d481a951abaabd1a2985c8959d8acb7103ed12e
Pull Request resolved: #31028
poteto added a commit that referenced this pull request Sep 23, 2024
I messed up the yml syntax and also realized that our script doesn't
currently handle renames or deletes, so I fixed that

ghstack-source-id: 7d481a951abaabd1a2985c8959d8acb7103ed12e
Pull Request resolved: #31028
@poteto poteto merged commit 2e1d261 into gh/poteto/6/base Sep 23, 2024
189 of 193 checks passed
poteto added a commit that referenced this pull request Sep 23, 2024
I messed up the yml syntax and also realized that our script doesn't
currently handle renames or deletes, so I fixed that

ghstack-source-id: 7d481a951abaabd1a2985c8959d8acb7103ed12e
Pull Request resolved: #31028
@poteto poteto deleted the gh/poteto/6/head branch September 23, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants