Monitor unknown attributes. #3104
Conversation
jimfb
force-pushed
the
monitor-stripped-attributes
branch
2 times, most recently
from
56e258e to
c8e6908
Compare
|
cc @sebmarkbage |
jimfb
force-pushed
the
monitor-stripped-attributes
branch
from
c8e6908 to
397c286
Compare
| transitionEnter, | ||
| transitionLeave, | ||
| ...transferredProps | ||
| } = this.props; |
There was a problem hiding this comment.
This will be slow since our transpiler isn't quite optimal here. :/
There was a problem hiding this comment.
Do we care? Is someone fixing the transpiler soon, or do you want me to use Object.assign and manually remove the object properties?
There was a problem hiding this comment.
I mostly just care about the linting.
|
@zpao Will this lead to unused variables warnings? |
|
We need to figure out lint here first. |
|
Ok, @zpao says to "put it up, wait for him to get back from his meeting, no good answer at the moment." |
jimfb
force-pushed
the
monitor-stripped-attributes
branch
from
397c286 to
2a512be
Compare
|
I’m closing because it’s been stale for a while, and there doesn’t appear to be consensus on how/whether to move forward with this. We can create a separate RFC issue if this is a part of a bigger plan but it’s hard to tell from a glance. |
Warn unknown attributes. Duplicates are handled by the deduping logic higher up in the same function.