fix[react-devtools]: removed redundant startProfiling call #31131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
EdmondChuiHW
approved these changes
Oct 8, 2024
No, because we have a checks inside both The main reason why I am removing it here, because we shouldn't be storing profiling settings in Agent, we can skip this step and just pass it from Hook -> Renderer. This is what is implemented in #31132. |
hoxyq
added a commit
that referenced
this pull request
Oct 9, 2024
Stacked on #31131. See last commit. This is a clean-up and a pre-requisite for next changes: 1. `ReloadAndProfileConfig` is now split into boolean value and settings object. This is mainly because I will add one more setting soon, and also because settings might be persisted for a longer time than the flag which signals if the Backend was reloaded for profiling. Ideally, this settings should probably be moved to the global Hook object, same as we did for console patching. 2. Host is now responsible for reseting the cached values, Backend will execute provided `onReloadAndProfileFlagsReset` callback.
This was referenced Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #31118. See last commit.
We don't need to call
startProfiling()here, because we delegate this to the Renderer itself:react/packages/react-devtools-shared/src/backend/fiber/renderer.js
Lines 5227 to 5232 in 830e823
Since this is de-facto the constructor of Renderer, this will be called earlier.
Validated via testing the reload-to-profile for Chrome browser extension.