[compiler][ez] Fix reanimated custom type defs for imports #31137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
josephsavona
reviewed
Oct 7, 2024
Comment on lines
691
to
695
| installReAnimatedTypes( | ||
| this.#moduleTypes, | ||
| this.#shapes, | ||
| REANIMATED_MODULE_NAME, | ||
| ); |
There was a problem hiding this comment.
Subtle design feedback here, but it's generally better to avoid mutating functions if possible. In this case, instead of installReanimatedTypes() this could be buildReanimatedTypes() which returns the same data type as moduleTypeResolver, and which we then install.
Alternatively, we could just pass #shapes and then return a type, which the caller (here) adds to moduleTypes
There was a problem hiding this comment.
Done! Thanks for the feedback
josephsavona
approved these changes
Oct 7, 2024
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we added support for Reanimated, we didn't distinguish between true globals (i.e. identifiers with no static resolutions), module types, and imports #29188. For the past 3-4 months, Reanimated imports were not being matched to the correct hook / function shape we match globals and module imports against two different registries.
This PR fixes our support for Reanimated library functions imported under
react-native-reanimated. See test fixtures for details