Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flight] don't emit chunks for rejected thenables after abort #31169

Merged
merged 1 commit into from
Oct 10, 2024
Merged

[Flight] don't emit chunks for rejected thenables after abort #31169

merged 1 commit into from
Oct 10, 2024

Commits on Oct 10, 2024

  1. [Flight] don't chunks for rejected thenables after abort 

    When aborting we emit chunks for each pending task. However there was a bug where a thenable could also reject before we could flush and we end up with an extra chunk throwing off the pendingChunks bookeeping. When a task is retried we skip it if is is not in PENDING status because we understand it was completed some other way. We need to replciate this for the reject pathway on serialized thenables since aborting if effectively completing all pending tasks and not something we need to continue to do once the thenable rejects later.
    @gnoff
    gnoff committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    86ae856 View commit details
    Browse the repository at this point in the history