Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unsued deps from React Compiler Babel plugin #31315

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Oct 22, 2024

Summary

Since the Babel plugin is bundled into a single file (except for @babel/types

const NO_INLINE = new Set(['@babel/types']);
) we can move these deps to devDependencies.

Main motivation is e.g. not installing ancient version of pretty-format (asked in #29062 without getting a reason, but if consumers can just skip the deps entirely that's even better).

How did you test this change?

I tested by installing the plugin into an empty project, deleting everything in node_modules except for babel-plugin-react-compiler and doing require('babel-plugin-react-compiler'). It still worked fine, so it should work in other cases as well 😀

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 0:11am

@poteto
Copy link
Member

poteto commented Oct 22, 2024

Oh thank you!

@poteto poteto merged commit ae90522 into facebook:main Oct 22, 2024
19 checks passed
@SimenB SimenB deleted the remove-babel-compiler-deps branch October 22, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants