Remove comment syntax from ReactNativeTypes #31457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Comparing: 372ec00...ccc7502 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
huntie
force-pushed
the
reactnativetypes-syntax
branch
from
dd769f2 to
d279459
Compare
|
V2: Address Prettier and ESLint errors on touched file. |
javache
approved these changes
Nov 8, 2024
huntie
force-pushed
the
reactnativetypes-syntax
branch
from
d279459 to
571b688
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
# Summary I'm working to get the main `react-native` package parsable by modern Flow tooling (both `flow-bundler`, `flow-api-translator`). This diff trivially removes some redundant Flow comment syntax in `ReactNativeTypes.js`, which fixes parsing under these newer tools. ## How did you test this change? Files were pasted into `react-native-github` under fbsource, where Flow validates ✅. DiffTrain build for [92b62f5](92b62f5)
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm working to get the main
react-nativepackage parsable by modern Flow tooling (bothflow-bundler,flow-api-translator).This diff trivially removes some redundant Flow comment syntax in
ReactNativeTypes.js, which fixes parsing under these newer tools.How did you test this change?
Files were pasted into
react-native-githubunder fbsource, where Flow validates ✅.