[compiler][ez] Clean up duplicate code in propagateScopeDeps #31581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
This was referenced Nov 19, 2024
Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.
mvitousek
reviewed
Dec 16, 2024
| return; | ||
| } | ||
| if (value.kind === 'PropertyLoad') { | ||
| context.visitProperty(value.object, value.property, false); |
There was a problem hiding this comment.
Doesn't seem to be a equivalent to the context.isUsedOutsideDeclaringScope(lvalue) check in the new version, is that a semantic change?
There was a problem hiding this comment.
Ahh that's because we already check context.isUsedOutsideDeclaringScope when building the temporaries sidemap. It's a bit awkward, but we need this information when constructing the temporaries sidemap because:
context.isUsedOutsideDeclaringScoperepresents a reordering barrier- the whole point of the temporaries sidemap is to represent reorderable / semantically equivalent expressions
- it's difficult to defer finding reordering barriers because they may affect multiple
temporariesentries i.e.PropertyLoadsfrom non-reorderable values
I originally duplicated this code to decouple temporary sidemap construction from dependency collection. But.. I think that made maintaining this code much more difficult. @mvitousek I'd love feedback on how to make this cleaner!
josephsavona
approved these changes
Dec 16, 2024
davesnx
added a commit
to davesnx/react
that referenced
this pull request
Dec 18, 2024
…act into issue-31578-setter-arity-gcc * 'issue-31578-setter-arity-gcc' of github.com:/davesnx/react: [flags] Clean up scheduler flags (facebook#31814) Enable debugRenderPhaseSideEffectsForStrictMode in test renderers (facebook#31761) Enable disableDefaultPropsExceptForClasses (facebook#31804) Turn on useModernStrictMode in test renderers (facebook#31769) [compiler][ez] Add shape for global Object.keys (facebook#31583) [compiler] Context variables as dependencies (facebook#31582) [compiler] Add fire to known React APIs (facebook#31795) [compiler] Add option for firing effect functions (facebook#31794) [compiler][be] Logger based debug printing in test runner (facebook#31809) [compiler][ez] Clean up duplicate code in propagateScopeDeps (facebook#31581) [compiler] Repro for aliased captures within inner function expressions (facebook#31770) [compiler][be] Playground now compiles entire program (facebook#31774) [Flight] Color and badge non-primary environments (facebook#31738) [Flight] Emit Deduped Server Components Marker (facebook#31737) [Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks (facebook#31736) Clean up context access profiling experiment (facebook#31806) [Flight] Stack Parallel Components in Separate Tracks (facebook#31735) Flag for requestPaint (facebook#31805)
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.
Stack created with Sapling. Best reviewed with ReviewStack.