Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated dependency in eslint-plugin-react-compiler #31629

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

rakleed
Copy link
Contributor

@rakleed rakleed commented Nov 24, 2024

Summary

Rreplace deprecated @babel/plugin-proposal-private-methods with @babel/plugin-transform-private-methods in eslint-plugin-react-compiler.

Closes #31481

How did you test this change?

When you install a plugin, there is no longer a warning about using a deprecated dependency.

…th `@babel/plugin-transform-private-methods`
Copy link

vercel bot commented Nov 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2024 7:46pm

@rakleed rakleed changed the title Replace deprecated dep @babel/plugin-proposal-private-methods Replace deprecated dependency in eslint-plugin-react-compiler Nov 24, 2024
@poteto
Copy link
Member

poteto commented Nov 25, 2024

thanks!

@poteto poteto merged commit 7670501 into facebook:main Nov 25, 2024
19 checks passed
mofeiZ added a commit that referenced this pull request Dec 3, 2024
mofeiZ added a commit that referenced this pull request Dec 3, 2024
…r`" (#31665)

Reverts #31629

`@babel/plugin-proposal-private-methods` is not compatible with
`@babel/traverse` versions < 7.25 (see
babel/babel#16851). Internally we have
partners that use a less modern babel version, and we expect this to be
an issue for older codebases in OSS as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Compiler Bug]: eslint-plugin-react-compiler: npm warn deprecated @babel/plugin-proposal-private-methods
3 participants