Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove enableAsyncActions #31757

Merged
merged 10 commits into from
Dec 13, 2024
Merged

Remove enableAsyncActions #31757

merged 10 commits into from
Dec 13, 2024

Conversation

rickhanlonii
Copy link
Member

Based on #31756

This is landed everywhere

@vercel Vercel
Copy link

vercel bot commented Dec 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 5:56pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 13, 2024
@react-sizebot
Copy link

react-sizebot commented Dec 13, 2024 •
edited
Loading

Comparing: fb12845...47a2df5

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 510.72 kB 510.41 kB = 91.37 kB 91.35 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 515.63 kB 515.32 kB = 92.07 kB 92.04 kB
facebook-www/ReactDOM-prod.classic.js = 595.55 kB 595.25 kB = 105.06 kB 105.02 kB
facebook-www/ReactDOM-prod.modern.js = 585.82 kB 585.51 kB = 103.49 kB 103.46 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-server/cjs/react-server-flight.production.js +0.28% 57.63 kB 57.80 kB +0.30% 11.60 kB 11.63 kB
oss-stable/react-server/cjs/react-server-flight.production.js +0.28% 57.63 kB 57.80 kB +0.30% 11.60 kB 11.63 kB
oss-experimental/react-server/cjs/react-server-flight.production.js +0.26% 62.40 kB 62.56 kB +0.28% 12.40 kB 12.44 kB
oss-stable/react-art/cjs/react-art.development.js = 555.48 kB 554.33 kB = 89.79 kB 89.67 kB
oss-stable-semver/react-art/cjs/react-art.development.js = 555.40 kB 554.25 kB = 89.77 kB 89.64 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js = 551.95 kB 550.80 kB = 90.09 kB 89.97 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js = 551.90 kB 550.75 kB = 90.08 kB 89.96 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js = 551.88 kB 550.73 kB = 90.07 kB 89.95 kB
oss-experimental/react-debug-tools/cjs/react-debug-tools.development.js = 32.08 kB 31.81 kB = 5.75 kB 5.73 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.development.js = 32.08 kB 31.81 kB = 5.75 kB 5.73 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.development.js = 32.08 kB 31.81 kB = 5.75 kB 5.73 kB
oss-experimental/react-debug-tools/cjs/react-debug-tools.production.js = 28.60 kB 28.34 kB = 5.62 kB 5.59 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.production.js = 28.60 kB 28.34 kB = 5.62 kB 5.59 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.production.js = 28.60 kB 28.34 kB = 5.62 kB 5.59 kB

Generated by 🚫 dangerJS against c23745d

@rickhanlonii
Merge branch 'main' into rh/rm-ff-asyncactions
2c82664 
# Conflicts:
#	packages/react-server/src/ReactFizzHooks.js
rickhanlonii
rickhanlonii commented Dec 13, 2024
View reviewed changes
packages/react-server/src/ReactFlightHooks.js
useHostTransitionStatus: (unsupportedHook: any),
useOptimistic: (unsupportedHook: any),
useFormState: (unsupportedHook: any),
useActionState: (unsupportedHook: any),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebmarkbage could you double check this? I don't think the flight dispatcher had these hooks defined before as unsupported.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, it doesn't really need it because the outer export shouldn't be available in that environment. This is just protecting against a misconfigured environment but it's good to have that backup so you know why.

@rickhanlonii rickhanlonii mentioned this pull request Dec 13, 2024
Merged
sebmarkbage
sebmarkbage reviewed Dec 13, 2024
View reviewed changes
packages/react-debug-tools/src/ReactDebugHooks.js
if (typeof Dispatcher.useActionState === 'function') {
// This type check is for Flow only.
Dispatcher.useActionState((s: mixed, p: mixed) => s, null);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is used by react-devtools on older versions of React so this check must still remain.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, so the comment about only being for Flow is wrong haha

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually no I'm wrong. This is the local dispatcher. Not the dispatcher ref.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this is the internal dispatcher, not the one in devtools

@rickhanlonii rickhanlonii merged commit ef63718 into facebook:main Dec 13, 2024
187 checks passed
@rickhanlonii rickhanlonii deleted the rh/rm-ff-asyncactions branch December 13, 2024 18:58
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
@rickhanlonii
Remove enableAsyncActions (#31757)
aa9b74a 
Based on #31756

This is landed everywhere

DiffTrain build for [ef63718](ef63718)
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
@rickhanlonii
Remove enableAsyncActions (#31757)
34f8925 
Based on #31756

This is landed everywhere

DiffTrain build for [ef63718](ef63718)
rickhanlonii added a commit that referenced this pull request Dec 13, 2024
@rickhanlonii
Remove enableBinaryflight (#31759)
08dfd0b 
Based off #31757

This has landed everywhere.
This was referenced Dec 18, 2024
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickhanlonii @react-sizebot @sebmarkbage @facebook-github-bot