Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix useResourceEffect in Fizz #31758

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Fix useResourceEffect in Fizz #31758

merged 2 commits into from
Dec 13, 2024

Conversation

jackpope
Copy link
Contributor

We're seeing errors when testing useResourceEffect in SSR and it turns out we're missing the noop dispatcher function on Fizz.

I tested a local build with this change and it resolved the late mutation errors in the e2e tests.

@vercel Vercel
Copy link

vercel bot commented Dec 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 4:14pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 13, 2024
@react-sizebot
Copy link

Comparing: 4dff0e6...47cb02f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 510.72 kB 510.72 kB = 91.37 kB 91.37 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 515.63 kB 515.63 kB = 92.07 kB 92.07 kB
facebook-www/ReactDOM-prod.classic.js = 595.55 kB 595.55 kB = 105.06 kB 105.06 kB
facebook-www/ReactDOM-prod.modern.js = 585.82 kB 585.82 kB = 103.49 kB 103.49 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against c54364c

poteto
poteto approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@poteto poteto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@jackpope jackpope merged commit 17ca4b1 into facebook:main Dec 13, 2024
187 checks passed
@jackpope jackpope deleted the use-resource-effect-server branch December 13, 2024 16:26
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
@jackpope
Fix useResourceEffect in Fizz (#31758)
5b45911 
We're seeing errors when testing useResourceEffect in SSR and it turns
out we're missing the noop dispatcher function on Fizz.

I tested a local build with this change and it resolved the late
mutation errors in the e2e tests.

DiffTrain build for [17ca4b1](17ca4b1)
This was referenced Dec 18, 2024
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poteto poteto poteto approved these changes

@rickhanlonii rickhanlonii Awaiting requested review from rickhanlonii

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackpope @react-sizebot @poteto @facebook-github-bot