Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --cleanup option to flags script to show groups of flags by status #31762

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

jackpope
Copy link
Contributor

yarn flags --cleanup will categorize flags to make it more clear which ones may need to be cleaned up, experiments checked on, or are blocked by internal rollouts.

Alternative to #31760

Screenshot 2024-12-13 at 2 31 30 PM

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 8:13pm

@@ -375,53 +381,86 @@ const FLAG_CONFIG = {

const FLAG_COLUMNS = Object.keys(FLAG_CONFIG);

const INTERNAL_VARIANTS = ['WWW Classic', 'WWW Modern', 'RN OSS'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be RN FB?

Suggested change
const INTERNAL_VARIANTS = ['WWW Classic', 'WWW Modern', 'RN OSS'];
const INTERNAL_VARIANTS = ['WWW Classic', 'WWW Modern', 'RN FB'];

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, updated

@react-sizebot
Copy link

react-sizebot commented Dec 13, 2024

Comparing: 08dfd0b...f55e191

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 510.41 kB 510.41 kB = 91.35 kB 91.35 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 515.32 kB 515.32 kB = 92.04 kB 92.04 kB
facebook-www/ReactDOM-prod.classic.js = 595.25 kB 595.25 kB = 105.02 kB 105.02 kB
facebook-www/ReactDOM-prod.modern.js = 585.51 kB 585.51 kB = 103.46 kB 103.46 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 013d5fa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants