-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --cleanup option to flags script to show groups of flags by status #31762
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
scripts/flags/flags.js
Outdated
@@ -375,53 +381,86 @@ const FLAG_CONFIG = { | |||
|
|||
const FLAG_COLUMNS = Object.keys(FLAG_CONFIG); | |||
|
|||
const INTERNAL_VARIANTS = ['WWW Classic', 'WWW Modern', 'RN OSS']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be RN FB?
const INTERNAL_VARIANTS = ['WWW Classic', 'WWW Modern', 'RN OSS']; | |
const INTERNAL_VARIANTS = ['WWW Classic', 'WWW Modern', 'RN FB']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, updated
Comparing: 08dfd0b...f55e191 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
yarn flags --cleanup
will categorize flags to make it more clear which ones may need to be cleaned up, experiments checked on, or are blocked by internal rollouts.Alternative to #31760