Remove enableComponentStackLocations #31764
Merged
+22
−192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
rickhanlonii
commented
Dec 13, 2024
| } else { | ||
| return describeFunctionComponentFrame(ctor); | ||
| } | ||
| return describeNativeComponentFrame(ctor, true); | ||
| } | ||
|
|
||
| export function describeFunctionComponentFrame(fn: Function): string { |
There was a problem hiding this comment.
@sebmarkbage we need to keep this old export to support old devtools versions right?
There was a problem hiding this comment.
DevTools has its own copy in DevToolsComponentStackFrame so it can be deleted.
There was a problem hiding this comment.
This export seems used by other places still though.
There was a problem hiding this comment.
I missed this before merging somehow: #31781
|
Comparing: 08dfd0b...5efb3ff Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sebmarkbage
approved these changes
Dec 13, 2024
rickhanlonii
added a commit
that referenced
this pull request
Dec 13, 2024
Base off #31764 This has landed everywhere
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has landed everywhere