[Fiber] Schedule passive effects using the regular ensureRootIsScheduled flow #31785
+161
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
commented
Dec 14, 2024
| @@ -595,7 +597,7 @@ describe('useSubscription', () => { | |||
| React.startTransition(() => { | |||
| mutate('C'); | |||
| }); | |||
| await waitFor(['render:first:C', 'render:second:C']); | |||
There was a problem hiding this comment.
I'm not sure about the intended semantics of waitFor but I'm confused it doesn't wait just as long or longer than waitForPaint.
sebmarkbage
commented
Dec 14, 2024
| @@ -755,10 +755,16 @@ describe('ReactExpiration', () => { | |||
|
|
|||
| // The update finishes without yielding. But it does not flush the effect. | |||
| await waitFor(['B1'], { | |||
| additionalLogsAfterAttemptingToYield: ['C1'], | |||
| additionalLogsAfterAttemptingToYield: gate( | |||
There was a problem hiding this comment.
I'm not sure what the expected semantics of this helper is and whether this change is expected.
sebmarkbage
commented
Dec 14, 2024
| @@ -911,9 +911,7 @@ describe('ReactDOMSelect', () => { | |||
| const container = document.createElement('div'); | |||
| const root = ReactDOMClient.createRoot(container); | |||
| async function changeView() { | |||
| await act(() => { | |||
There was a problem hiding this comment.
This triggers the interleave act warning but that should've already happened before since the dispatch is wrapped by act. So this is fixing something but not sure why this wasn't already erroring before.
|
Comparing: f5077bc...63391b6 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
sebmarkbage
force-pushed
the
yieldpassive
branch
from
3dee103 to
49e51b2
Compare
This treats workInProgressRoot work and rootWithPendingPassiveEffects the same way. Basically as long as there's some work on the root, yield the current task. Including passive effects.
The ReactDOMSelect has an overlapping act error but I don't know why that wasn't erroring before. I also don't get why waitFor isn't enough for useSubscription. Nor why ReactExpiration changes. What does the additionalLogsAfterAttemptingToYield helper do?
sebmarkbage
force-pushed
the
yieldpassive
branch
from
49e51b2 to
9b7be25
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
…led flow (#31785) This treats workInProgressRoot work and rootWithPendingPassiveEffects the same way. Basically as long as there's some work on the root, yield the current task. Including passive effects. This means that passive effects are now a continuation instead of a separate callback. This can mean they're earlier or later than before. Later for Idle in case there's other non-React work. Earlier for same Default if there's other Default priority work. This makes sense since increasing priority of the passive effects beyond Idle doesn't really make sense for an Idle render. However, for any given render at same priority it's more important to complete this work than start something new. Since we special case continuations to always yield to the browser, this has the same effect as #31784 without implementing `requestPaint`. At least assuming nothing else calls `requestPaint`. <img width="587" alt="Screenshot 2024-12-14 at 5 37 37 PM" src="https://github.com/user-attachments/assets/8641b172-8842-4191-8bf0-50cbe263a30c" /> DiffTrain build for [facec3e](facec3e)
github-actions bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
…led flow (#31785) This treats workInProgressRoot work and rootWithPendingPassiveEffects the same way. Basically as long as there's some work on the root, yield the current task. Including passive effects. This means that passive effects are now a continuation instead of a separate callback. This can mean they're earlier or later than before. Later for Idle in case there's other non-React work. Earlier for same Default if there's other Default priority work. This makes sense since increasing priority of the passive effects beyond Idle doesn't really make sense for an Idle render. However, for any given render at same priority it's more important to complete this work than start something new. Since we special case continuations to always yield to the browser, this has the same effect as #31784 without implementing `requestPaint`. At least assuming nothing else calls `requestPaint`. <img width="587" alt="Screenshot 2024-12-14 at 5 37 37 PM" src="https://github.com/user-attachments/assets/8641b172-8842-4191-8bf0-50cbe263a30c" /> DiffTrain build for [facec3e](facec3e)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Dec 18, 2024
…led flow (facebook#31785) This treats workInProgressRoot work and rootWithPendingPassiveEffects the same way. Basically as long as there's some work on the root, yield the current task. Including passive effects. This means that passive effects are now a continuation instead of a separate callback. This can mean they're earlier or later than before. Later for Idle in case there's other non-React work. Earlier for same Default if there's other Default priority work. This makes sense since increasing priority of the passive effects beyond Idle doesn't really make sense for an Idle render. However, for any given render at same priority it's more important to complete this work than start something new. Since we special case continuations to always yield to the browser, this has the same effect as facebook#31784 without implementing `requestPaint`. At least assuming nothing else calls `requestPaint`. <img width="587" alt="Screenshot 2024-12-14 at 5 37 37 PM" src="https://github.com/user-attachments/assets/8641b172-8842-4191-8bf0-50cbe263a30c" /> DiffTrain build for [facec3e](facebook@facec3e)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Dec 18, 2024
…led flow (facebook#31785) This treats workInProgressRoot work and rootWithPendingPassiveEffects the same way. Basically as long as there's some work on the root, yield the current task. Including passive effects. This means that passive effects are now a continuation instead of a separate callback. This can mean they're earlier or later than before. Later for Idle in case there's other non-React work. Earlier for same Default if there's other Default priority work. This makes sense since increasing priority of the passive effects beyond Idle doesn't really make sense for an Idle render. However, for any given render at same priority it's more important to complete this work than start something new. Since we special case continuations to always yield to the browser, this has the same effect as facebook#31784 without implementing `requestPaint`. At least assuming nothing else calls `requestPaint`. <img width="587" alt="Screenshot 2024-12-14 at 5 37 37 PM" src="https://github.com/user-attachments/assets/8641b172-8842-4191-8bf0-50cbe263a30c" /> DiffTrain build for [facec3e](facebook@facec3e)
This was referenced Dec 18, 2024
jackpope
added a commit
that referenced
this pull request
Dec 20, 2024
#31785 turned on `enableYieldingBeforePassive` for the internal test renderer builds. We have some failing tests on the RN side blocking the sync so lets turn these off for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This treats workInProgressRoot work and rootWithPendingPassiveEffects the same way. Basically as long as there's some work on the root, yield the current task. Including passive effects. This means that passive effects are now a continuation instead of a separate callback. This can mean they're earlier or later than before. Later for Idle in case there's other non-React work. Earlier for same Default if there's other Default priority work.
This makes sense since increasing priority of the passive effects beyond Idle doesn't really make sense for an Idle render.
However, for any given render at same priority it's more important to complete this work than start something new.
Since we special case continuations to always yield to the browser, this has the same effect as #31784 without implementing
requestPaint. At least assuming nothing else callsrequestPaint.