Added warning for use of ReactLink. #5032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimfb
force-pushed
the
remove-react-link
branch
from
c32b3ec to
7c652fe
Compare
| if (props.valueLink !== undefined && !didWarnValueLink) { | ||
| warning( | ||
| false, | ||
| '`.valueLink` on `input` is deprecated; set `.value` and `.onChange` instead.' |
There was a problem hiding this comment.
nit: can we not have dots before all of these?
nit: checkedLink too?
nit: might be simpler to put this logic in LinkedValueUtils instead of in each wrapper.
There was a problem hiding this comment.
Removed dots, added checked link.
Didn't want to put the warnings in LinkedValueUtils because I'm expecting that that class will be used in the addons/wrapper for anyone who wants to reuse the valuelink behavior in their apps/components, and they won't want to see the warning.
jimfb
force-pushed
the
remove-react-link
branch
2 times, most recently
from
efc24b5 to
381540a
Compare
jimfb
force-pushed
the
remove-react-link
branch
from
381540a to
c103c8d
Compare
jimfb
added a commit
that referenced
this pull request
Oct 7, 2015
Added warning for use of ReactLink.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added warning for use of ReactLink. First step toward fixing #2302