-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove setProps and replaceProps. #5570
Conversation
👍 Can we get rid of TopLevelWrapper now? I don't remember. |
I don't remember either, but we would probably need it for setstate/replacestate, right? relevant diff: 643651b |
That was so that we could enqueue updates to native components in the same way as composites – native components don't have setState so it might be irrelevant now. |
Ok, removing |
Remove setProps and replaceProps.
Since getDomNode was removed. Is it possible to focus a list item? Any suggestions? Doc link I could follow. Thanks |
Is this a question about React or about DOM in general? In React, you no longer need As to how I hope this helps! |
@trigun539 You need to add a ref to the input element. See the docs for more details: |
@trigun539 @gaearon Have used something like this in one of my implementations for focusing an input element. Not sure if this is the best way but I am pretty sure this can help.
Where you can control the |
Thanks for the help. |
I guess the real issue was related to this and not react: http://stackoverflow.com/questions/30213603/javascript-not-able-to-set-focus-to-first-li-element-within-ul. Thanks again. @gaearon @spicyj @laumair Added the tab index and worked great! |
Remove setProps and replaceProps.