-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5726 #5727
Fix #5726 #5727
Conversation
Add support for SVG stroke-linejoin attribute
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Note: we will probably not take this. We're working on an effort to allow all SVG attributes to pass through in #5714. |
@zpao That's great. In fact I believe that you shall let all attributes pass through and just convert them from CamelCase to hifenated forms if react doesn't recognize the attribute. I believe that this should be closed then |
👍 I'm going to leave it open for the time being and we'll close all of the SVG issues/PRs in bulk (to make sure we haven't missed anything). |
The current thinking in #5714 is not to be smart about it and to pass them through exactly as the user specifies. This way we don't need to care whether we are aware of all possible camel cased attributes that really are camel cased in the spec (there are quite a few!) The existing camel cased attributes will work with a warning for another version. |
Verified that |
Add support for SVG stroke-linejoin attribute
See #5726