Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved LinkedInput from addons to packages. #6127

Merged
merged 1 commit into from
Feb 26, 2016

Conversation

jimfb
Copy link
Contributor

@jimfb jimfb commented Feb 26, 2016

Moved LinkedInput from addons to packages.

@jimfb
Copy link
Contributor Author

jimfb commented Feb 26, 2016

@zpao

@@ -0,0 +1,25 @@
{
"name": "react-linked-input",
"version": "0.0.201602251656",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just make this 1.0.0

@zpao
Copy link
Member

zpao commented Feb 26, 2016

And github doesn't let me comment outside the context so …

Let's remove the providesModule header too

@jimfb jimfb force-pushed the LinkedInput-to-packages branch from d997dcc to 0e333cf Compare February 26, 2016 01:24
@facebook-github-bot
Copy link

@jimfb updated the pull request.

var ReactDOM = require('react-dom');
var LinkedInput = require('react-linked-input');

React.render(<LinkedInput valueLink={{value: 'boo', requestChange: function() {}}} />, container);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to wrap this code so it looks good on npm.

@jimfb jimfb force-pushed the LinkedInput-to-packages branch from 0e333cf to 8ab15c1 Compare February 26, 2016 01:49
@facebook-github-bot
Copy link

@jimfb updated the pull request.

jimfb added a commit that referenced this pull request Feb 26, 2016
Moved LinkedInput from addons to packages.
@jimfb jimfb merged commit 1387188 into facebook:master Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants