Test to verify findDOMNode does not throw in willMount #6305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| it('findDOMNode should not throw an error when called within a component that is not mounted', function() { | ||
| var Bar = React.createClass({ | ||
| componentWillMount: function() { | ||
| ReactDOM.findDOMNode(this); |
There was a problem hiding this comment.
Should we assert its return value here too?
There was a problem hiding this comment.
As in, add an expect call within componentWillMount? Sure!
Adds a test to prevent a regression of throwing an error when calling `findDOMNode(this)` in a component's `componentWillMount` function. This previously used to throw an invariant violation but now does not any more.
|
Done! re-review? @gaearon |
|
@maherbeg updated the pull request. |
|
Thanks @maherbeg! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test to prevent a regression of throwing an error when
calling
findDOMNode(this)in a component'scomponentWillMountfunction. This previously used to throw an invariant violation but
now does not any more.
Fixes #4999