Fixed removing attributes during custom element update. Fixes #6747 #6748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
Looks good to me ( 👍 ) |
|
@jimfb Thanks for a such a quick review! I would really appreciate if you could let me know on the next steps so I can either setup our infrastructure around my fork, or wait for merge to master / next release. Thanks in advance. |
|
@grassator Merged into master. This should make it into one of the upcoming releases. |
|
@jimfb Thanks a lot for an expedited handling — it's really appreciated. |
| node.removeAttribute(name); | ||
| if (__DEV__) { | ||
| ReactDOMInstrumentation.debugTool.onDeleteValueForProperty(node, name); | ||
| ReactInstrumentation.debugTool.onNativeOperation( |
There was a problem hiding this comment.
Note: this method was renamed in #6754 which causes tests to fail now.
|
@gaearon sorry about that—I didn't know about upcoming rename. |
|
Yea, no problem! |
zpao
pushed a commit
to zpao/react
that referenced
this pull request
Jun 8, 2016
…k#6747 (facebook#6748) (cherry picked from commit 0e889d7)
zpao
pushed a commit
that referenced
this pull request
Jun 14, 2016
jscissr
added a commit
to jscissr/react-polymer
that referenced
this pull request
Jul 5, 2016
Fix after facebook/react#6748 broke the monkey-patching
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to follow the same approach as the
nextPropstakes, which involved adding a new method to explicitly delete the attribute without all the checks React does.I would be happy to any necessary changes and hope it can be merged soon.
Thanks
Fixes #6747.