Copy React ART tests and add hacks to fix them #6775
Conversation
|
@facebook/react-core This is kinda icky. My native/host rename mucked this up (getNativeNode) but the devtools warns about missing debug IDs too before this change. We can't really change React ART because we have no way to guarantee that people aren't using React ART v15 with React 15.1. |
|
Well, apparently we haven't published React ART 15.0. But the point stands, I think. |
ghost
added
|
Can we just actually ship ReactART's source inside the |
|
@spicyj updated the pull request. |
Isn't that the opposite of what we want to do with renderers? |
|
Ehh… React ART is weird because it isn't its own environment so we can't make things completely separate. Unlike React DOM and React Native where it's okay if they have different versions (and we don't want them to share any state or code). Maybe we can try to make React ART more independent (and that might be a good idea anyway) but we're not set up for that right now. |
|
ART doesn't depend on shared state other than owner and current context. Just copying all the files from React to ART should be sufficient too. The question is, if we keep going in the opposite direction of decoupling, when will we ever get to a decoupled state? What spin off effects will we get from doing this?
|
|
Okay, we don't have to merge them. Does this PR look good though? I want to be able to test against React ART even if we consider them decoupled. |
| // We renamed this. Allow the old name for compat. :( | ||
| if (!instance.getHostNode) { | ||
| instance.getHostNode = instance.getNativeNode; | ||
| } |
There was a problem hiding this comment.
Since we didn't ship ReactART 15 yet… we could just make it depend on 15.1 and not support 15.0.
This helps us make sure we don't break React ART in a minor or patch release. The idea is to not change these files when making minor or patch changes. Copied directly from react-art with requires fixed. (I also picked a different haste name just in case.)
|
@spicyj updated the pull request. |
Copy React ART tests and add hacks to fix them (cherry picked from commit 531a6b3)
Copy React ART tests and add hacks to fix them (cherry picked from commit 531a6b3)
This helps us make sure we don't break React ART in a minor or patch release. The idea is to not change these files when making minor or patch changes. Copied directly from react-art with requires fixed. (I also picked a different haste name just in case.)
Then I fixed the tests.