Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed transitionAppearTimeout to remove warning #7165

Merged
merged 1 commit into from
Jul 2, 2016

Conversation

batusai513
Copy link
Contributor

  • Removed the prop transitionAppearTimeout from
    addons/transitions/ReactTransitionGroup in order to remove a warning
    when passing unknown props to DOM elements.

- Removed the prop transitionAppearTimeout from
addons/transitions/ReactTransitionGroup in order to remove a warning
when passing unknown props to DOM elements.
@ghost
Copy link

ghost commented Jul 1, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@gaearon
Copy link
Collaborator

gaearon commented Jul 2, 2016

Are you sure you have signed the CLA? Can you try again, or write to cla@fb.com if it didn’t work?

@ghost
Copy link

ghost commented Jul 2, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ghost ghost added the CLA Signed label Jul 2, 2016
@gaearon gaearon merged commit 6e5dd89 into facebook:master Jul 2, 2016
@gaearon
Copy link
Collaborator

gaearon commented Jul 2, 2016

Thanks!

@batusai513
Copy link
Contributor Author

@Gearon, you are welcome, I'm glad to help

@mariajplmiranda
Copy link

I'm having the same issue here. When are you considering to publish this fix?

@gaearon
Copy link
Collaborator

gaearon commented Jul 4, 2016

@mariajplmiranda I would expect it to be published within a week.

@gaearon gaearon added this to the 15-next milestone Jul 5, 2016
@oponder oponder mentioned this pull request Jul 7, 2016
3 tasks
zpao pushed a commit that referenced this pull request Jul 8, 2016
- Removed the prop transitionAppearTimeout from
addons/transitions/ReactTransitionGroup in order to remove a warning
when passing unknown props to DOM elements.
(cherry picked from commit 6e5dd89)
@zpao zpao modified the milestones: 15-next, 15.2.1 Jul 8, 2016
usmanajmal pushed a commit to usmanajmal/react that referenced this pull request Jul 11, 2016
- Removed the prop transitionAppearTimeout from
addons/transitions/ReactTransitionGroup in order to remove a warning
when passing unknown props to DOM elements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants