Pass shouldHaveDebugID flag to instantiateComponent #7193
Merged
+159
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
|
||
| var Anon = React.createClass({displayName: null, render: () => null}); |
There was a problem hiding this comment.
These changes are just indentation. I moved an existing test into a common describe and added two more tests based on the issue reports.
|
Is it possible to just pass in a flag to instantiateReactComponent instead for whether to skip assigning a debug ID? That feels nicer than ad hoc fields. |
gaearon
changed the title
|
Updated. |
|
Can you pass |
|
I think I did that, did I miss a callsite? |
|
More specifically:
|
|
Oh weird, I think it wasn't showing me all the files. Looks great. |
usmanajmal
pushed a commit
to usmanajmal/react
that referenced
this pull request
Jul 11, 2016
* Add failing tests for facebook#7187 and facebook#7190 * Pass shouldHaveDebugID flag to instantiateComponent This allows us to remove a hack that was added in facebook#6770 and caused facebook#7187 and facebook#7190. * Move logic for choosing whether to use debugID outside instantiate
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to remove a hack that was added in #6770.
That hack caused #7187 and #7190 so this is an alternative fix to the same problem.