Improve validateDOMNesting message for whitespace #7515
Merged
+49
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| tagDisplayName = 'Whitespace text nodes'; | ||
| whitespaceInfo = | ||
| ' Make sure you don\'t have any extra whitespace between tags on ' + |
There was a problem hiding this comment.
Could this message be confusing? Whitespace doesn't matter between JSX tags -- doesn't this problem only occur when there's whitespace inside a variable?
Edit: Nevermind, per this blog post, whitespace can appear when:
Element nodes will maintain white space when mixed with with non-element nodes on the same physical line of JSX code.
There was a problem hiding this comment.
Whitespace between tags on a single line matters, and I believe that's the most common cause of extra whitespace. See "Foo" in the test case below.
There was a problem hiding this comment.
Aha, didn't know that. I guess that makes sense, but it's not something you normally think about! (Which is why this warning is helpful!)
|
👍 |
ghost
added
the
4 tasks
zpao
pushed a commit
that referenced
this pull request
Sep 15, 2016
This was referenced Oct 4, 2016
Closed
1 task
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #5071.