Add 'as' keyword (#7543) #7582
Merged
Add 'as' keyword (#7543) #7582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,6 +36,8 @@ var HTMLDOMPropertyConfig = { | |||
| allowFullScreen: HAS_BOOLEAN_VALUE, | |||
| allowTransparency: 0, | |||
| alt: 0, | |||
| /* 'as' is introduced to links with 'preload' type: https://w3c.github.io/preload/ */ | |||
There was a problem hiding this comment.
nitpick, but can you use a single line comment instead of a block comment? Just so it's consistent. Also, I think you can just remove the link to the W3C standard 👍
There was a problem hiding this comment.
yep, definitely. changed and pushed
ghost
added
GH Review: review-needed
CLA Signed
and removed
GH Review: needs-revision
labels
| @@ -36,6 +36,8 @@ var HTMLDOMPropertyConfig = { | |||
| allowFullScreen: HAS_BOOLEAN_VALUE, | |||
| allowTransparency: 0, | |||
| alt: 0, | |||
| // 'as' is keyword to links with 'preload' type | |||
There was a problem hiding this comment.
One last thing: I think the grammar might be a little bit confusing as-is. Can we change this to:
// specifies target context for links with `preload` typeThat's more in line with how the spec describes it as well. After that I think we can merge 👍
ghost
added
GH Review: review-needed
CLA Signed
and removed
GH Review: needs-revision
labels
|
@kevinslin thanks again! |
zpao
pushed a commit
that referenced
this pull request
Sep 15, 2016
kaelig
added a commit
to kaelig/DefinitelyTyped
that referenced
this pull request
Oct 17, 2017
See corresponding addition here: facebook/react#7582
8 tasks
johnnyreilly
pushed a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Oct 22, 2017
* Add "as" attribute to links See corresponding addition here: facebook/react#7582 * Add "as" attribute to link elements in React v16 definition * Turn commas into semicolons (React 15) * Turn commas into semicolons (React 16)
awkay
pushed a commit
to fulcrologic/fulcro
that referenced
this pull request
Dec 3, 2017
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure the following is done...
master.grunt test).grunt lint) - we've done our best to make sure these rules match our internal linting guidelines.