Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support iframes (nested browsing contexts) in selection event handling #7866

Closed
wants to merge 5 commits into from
Closed

Support iframes (nested browsing contexts) in selection event handling #7866

wants to merge 5 commits into from

Commits on Oct 4, 2016

  1. More accurate jsdoc comments

    @acusti
    acusti committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    74e565d View commit details
    Browse the repository at this point in the history

  2. Avoid global document and window objects, facebook#427

    @acusti
    acusti committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    2c2b5ad View commit details
    Browse the repository at this point in the history

  3. Make getting/setting selection check iframe contents 

    If an input inside a same-domain iframe is the actual activeElement,
this change will make the ReactInputSelection module get from and
restore selection to that input, rather than the iframe element itself
    @acusti
    acusti committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    a525379 View commit details
    Browse the repository at this point in the history

  4. Use event target doc as getActiveElement context 

    Depends on facebook/fbjs#188
    @acusti
    acusti committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    dda228b View commit details
    Browse the repository at this point in the history

  5. Add tests for ReactInputSelection 

    Had to remove some tests because they rely on DOM functionality that
jsdom doesn’t yet support, like getSelection and iframe activeElement
    @acusti
    acusti committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    6b17090 View commit details
    Browse the repository at this point in the history