-
Notifications
You must be signed in to change notification settings - Fork 46.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fiber] Fix some of the warnings #8570
Commits on Dec 14, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 7bc8f36 - Browse repository at this point
Copy the full SHA 7bc8f36View commit details -
Keep Fiber debug source up to date
When an element changes, we should copy the source and owner again. Otherwise they can get stale since we're not reading them from the element.
Configuration menu - View commit details
-
Copy full SHA for c456f7d - Browse repository at this point
Copy the full SHA c456f7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 18808a1 - Browse repository at this point
Copy the full SHA 18808a1View commit details -
Explicitly specify Fiber types to include in the stack
Fixes an accidental omission when both source and owner are null but displayName exists.
Configuration menu - View commit details
-
Copy full SHA for d501676 - Browse repository at this point
Copy the full SHA d501676View commit details -
Fix mised Stack+Fiber test to not expect extra warnings
When we're in Fiber mode we don't actually expect that warning being printed.
Configuration menu - View commit details
-
Copy full SHA for ddae7db - Browse repository at this point
Copy the full SHA ddae7dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa92f74 - Browse repository at this point
Copy the full SHA aa92f74View commit details -
Implement duplicate key warnings
We keep known keys in a set in development. There is an annoying special case where we know we'll check it again because we break out of the loop early. One test in the tree hook regresses to the failing state because it checks that the tree hook works without a Set available, but we started using Set in this code. It is not essential and we can clean this up later when we decide how to deal with polyfills.
Configuration menu - View commit details
-
Copy full SHA for dbb62a9 - Browse repository at this point
Copy the full SHA dbb62a9View commit details -
Move ReactTypeOfWork to src/shared
It needs to be available both to Fiber and Isomorphic because the tree hook lives in Isomorphic but pretty-prints Fiber stack.
Configuration menu - View commit details
-
Copy full SHA for 8f544a7 - Browse repository at this point
Copy the full SHA 8f544a7View commit details -
Add dev-only ReactDebugCurrentFiber for warnings
The goal is to use ReactCurrentOwner less and rely on ReactDebugCurrentFiber for warning owner name and stack.
Configuration menu - View commit details
-
Copy full SHA for 6796336 - Browse repository at this point
Copy the full SHA 6796336View commit details -
Make Stack invariant messages more consistent
Fiber used a helper so two tests had the same phrasing. Stack also used a helper for most invariants but hardcoded a different phrase in one place. I changed that invariant message to use a helper which made it consistent with what it prints in Fiber.
Configuration menu - View commit details
-
Copy full SHA for 655a763 - Browse repository at this point
Copy the full SHA 655a763View commit details
Commits on Dec 15, 2016
-
Make CSSPropertyOperations use getCurrentFiberOwnerName()
This gets mount-time CSS warnings to be printed. However update-time warnings are currently ignored because current fiber is not yet available during the commit phase. We also regress on HostOperation hook tests but this doesn't matter because it's only used by ReactPerf and it doesn't work with Fiber yet anyway. We'll have to think more about it later.
Configuration menu - View commit details
-
Copy full SHA for 7566a14 - Browse repository at this point
Copy the full SHA 7566a14View commit details -
Set ReactDebugCurrentFiber during the commit phase
This makes it available during updates, fixing the last failing test in CSSPropertyOperations.
Configuration menu - View commit details
-
Copy full SHA for 080330a - Browse repository at this point
Copy the full SHA 080330aView commit details -
Add DOM warnings by calling hooks directly
It is not clear if the old hook system is worth it in its generic incarnation. For now I am just hooking it up to the DOMFiber renderer directly.
Configuration menu - View commit details
-
Copy full SHA for bc6bd20 - Browse repository at this point
Copy the full SHA bc6bd20View commit details -
Add client-side counterparts for some warning tests
This helps us track which warnings are really failing in Fiber, and which ones depend on SSR.
Configuration menu - View commit details
-
Copy full SHA for 837e683 - Browse repository at this point
Copy the full SHA 837e683View commit details