Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypick warning and removal of react create class #9771

Merged
merged 6 commits into from
May 25, 2017
Merged

Cherrypick warning and removal of react create class #9771

merged 6 commits into from
May 25, 2017

Commits on May 25, 2017

  1. react-create-class -> create-react-class

    @acdlite @flarnie
    acdlite authored and flarnie committed May 25, 2017
    Configuration menu
    Copy the full SHA
    4c9c859 View commit details
    Browse the repository at this point in the history

  2. Fix issues/bugs introduced by merge conflict resolution 

    **what is the change?:**
A couple of bugs and holes were introduced when cherry-picking facebook#9232 onto the 15.6 branch. This fixes them.
We also needed to add some logic from facebook#9399

**why make this change?:**
To keep tests passing and get this change working.

**test plan:**
`yarn test`

**issue:**
facebook#9398
    @flarnie
    flarnie committed May 25, 2017
    Configuration menu
    Copy the full SHA
    68d3370 View commit details
    Browse the repository at this point in the history

  3. Move component base classes into a single file (facebook#8918)

    @gaearon @flarnie
    gaearon authored and flarnie committed May 25, 2017
    Configuration menu
    Copy the full SHA
    3d1062b View commit details
    Browse the repository at this point in the history

  4. More fixes for issues introduced by rebasing 

    **what is the change?:**
- Remove some outdated 'require' statements that got orphaned in 'React.js'
- Change 'warning' to 'lowPriorityWarning' for 'React.createClass'
- Fix syntax issues in 'React-test'
- Use 'creatReactClass' instead of ES6 class in ReactART
- Update 'prop-type' dependency to use no higher than 15.7 because 15.8 limits the number of warnings, and this causes a test to fail.
- Fix some mixed-up and misnamed variables in `React.js`
- Rebase onto commit that updates deprecation messages
- Update a test based on new deprecation messages

**why make this change?:**
These were bugs introduced by rebasing and tests caught the regressions.

**test plan:**
`yarn test`

**issue:**
facebook#9398
    @flarnie
    flarnie committed May 25, 2017
    Configuration menu
    Copy the full SHA
    27bbbec View commit details
    Browse the repository at this point in the history

  5. Reset yarn.lock 

    **what is the change?:**
I didn't mean to commit changes to `yarn.lock` except for the `prop-types` and `create-react-class` updates.

**why make this change?:**
To minimize the changes we make to dependency versions.

**test plan:**
`rm -rf node_modules`
`yarn install`
`yarn run build`
`yarn test`
    @flarnie
    flarnie committed May 25, 2017
    Configuration menu
    Copy the full SHA
    0e2e7b2 View commit details
    Browse the repository at this point in the history

  6. Run yarn prettier

    @flarnie
    flarnie committed May 25, 2017
    Configuration menu
    Copy the full SHA
    4a83c04 View commit details
    Browse the repository at this point in the history