Remove relay-conifg #3677
Closed
Remove relay-conifg #3677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rbalicki2 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Can you ship an npm release before this is removed, it's still empty and people won't know that it isn't valid for 13+ - https://www.npmjs.com/package/relay-config |
|
@orta do you mean ship README changes to NPM? |
|
Yeah, #3656 added a README but never got deployed to npm |
|
Oh, I'll try to publish a custom 12.0.1 tomorrow. But what's interesting all our packages are missing README on NPM, so there's probably something we need to fix in our bundler/publish script to include these files. |
|
ah, that makes sense - ha |
|
I published 12.0.1 with README https://www.npmjs.com/package/relay-config |
|
Ace, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package were used with in v12 with
relay-compiler. Now we have this config parser (or similar) implemented in rust. So we don't need this.Test Plan: