[Relay] don't use the reserved word "await" as a method name #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently `await` is missing from some lists of reserved words. Typically Babel or minifiers should quote `await` like they quote `function`. Instead of waiting for changes in Babel or webpack to trickle down, let's rename this for now. Fixes facebook#665.
|
@facebook-github-bot import |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1056988307667078/int_phab to review. |
|
Thanks for the PR. +1 |
|
is this fix going to be published to npm soon? thanks! |
|
@gschammah Yes, we're planning on publishing 0.7.0 on Wednesday. |
|
@kassens any update on this? |
|
This is currently an issue (on relay I've asked for a maintenance release, because the incompatibility lies in the babel packages themselves. |
This was referenced May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently
awaitis missing from some lists of reserved words. Typically Babel or minifiers should quoteawaitlike they quotefunctioninvar x = {function: 1, await: 2}.Instead of waiting for changes in Babel or webpack to trickle down, let's rename this for now.
Fixes #665.