Skip to content

Commit

Permalink
Fix old comment about HyperClockCache and SecondaryCache (#11517)
Browse files Browse the repository at this point in the history
Summary:
Support was added in 8.1.0

Pull Request resolved: #11517

Test Plan: comments only

Reviewed By: anand1976

Differential Revision: D46489929

Pulled By: pdillinger

fbshipit-source-id: 4fd30078389065c9ec225bf55b6773f1641f0646
  • Loading branch information
pdillinger committed Jun 9, 2023
1 parent b36f691 commit 32c6de7
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion include/rocksdb/cache.h
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,6 @@ inline std::shared_ptr<SecondaryCache> NewCompressedSecondaryCache(
// * Requires an extra tuning parameter: see estimated_entry_charge below.
// Similarly, substantially changing the capacity with SetCapacity could
// harm efficiency.
// * SecondaryCache is not yet supported.
// * Cache priorities are less aggressively enforced, which could cause
// cache dilution from long range scans (unless they use fill_cache=false).
// * Can be worse for small caches, because if almost all of a cache shard is
Expand Down

0 comments on commit 32c6de7

Please sign in to comment.