Fix build with gcc 13 by including <cstdint> #11118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like other versions before, gcc 13 moved some includes around and as a
result <cstdint> is no longer transitively included [1]. Explicitly include
it for uint{32,64}_t.
[1] https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes
heirecka
force-pushed
the
fix-build-with-gcc-13
branch
from
39581e8
to
fe4d03d
Compare
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
tserong
added a commit
to SUSE/ceph
that referenced
this pull request
Mar 8, 2023
This applies three patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 - A tweak to db/compaction/compaction_iteration_stats.h, lifted from https://src.fedoraproject.org/rpms/ceph/blob/rawhide/f/0024-gcc-13.patch Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
tserong
added a commit
to SUSE/ceph
that referenced
this pull request
Mar 8, 2023
This applies three patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 - A tweak to db/compaction/compaction_iteration_stats.h, lifted from https://src.fedoraproject.org/rpms/ceph/blob/rawhide/f/0024-gcc-13.patch Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
tserong
added a commit
to SUSE/ceph
that referenced
this pull request
Mar 8, 2023
This applies two patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
tserong
added a commit
to SUSE/ceph
that referenced
this pull request
Mar 9, 2023
This applies three patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 - A tweak to db/compaction/compaction_iteration_stats.h, lifted from https://src.fedoraproject.org/rpms/ceph/blob/rawhide/f/0024-gcc-13.patch Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
tserong
added a commit
to SUSE/ceph
that referenced
this pull request
Mar 9, 2023
This applies two patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
tserong
added a commit
to SUSE/ceph
that referenced
this pull request
Mar 9, 2023
This applies two patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
tserong
added a commit
to SUSE/ceph
that referenced
this pull request
Mar 9, 2023
This applies three patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 - A tweak to db/compaction/compaction_iteration_stats.h, lifted from https://src.fedoraproject.org/rpms/ceph/blob/rawhide/f/0024-gcc-13.patch Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
mgfritch
pushed a commit
to SUSE/ceph
that referenced
this pull request
Apr 19, 2023
This applies three patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 - A tweak to db/compaction/compaction_iteration_stats.h, lifted from https://src.fedoraproject.org/rpms/ceph/blob/rawhide/f/0024-gcc-13.patch Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
mgfritch
pushed a commit
to SUSE/ceph
that referenced
this pull request
May 10, 2023
This applies three patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 - A tweak to db/compaction/compaction_iteration_stats.h, lifted from https://src.fedoraproject.org/rpms/ceph/blob/rawhide/f/0024-gcc-13.patch Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
2 tasks
rzarzynski
pushed a commit
to ceph/rocksdb
that referenced
this pull request
May 24, 2023
Summary:
Like other versions before, gcc 13 moved some includes around and as a result <cstdint> is no longer transitively included [1]. Explicitly include it for uint{32,64}_t.
[1] https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes
Pull Request resolved: facebook#11118
Reviewed By: cbi42
Differential Revision: D42711356
Pulled By: ajkr
fbshipit-source-id: 5ea257b85b7017f40fd8fdbce965336da95c55b2
(cherry picked from commit 88edfbf)
jsteemann
pushed a commit
to arangodb/rocksdb
that referenced
this pull request
May 26, 2023
Summary:
Like other versions before, gcc 13 moved some includes around and as a result <cstdint> is no longer transitively included [1]. Explicitly include it for uint{32,64}_t.
[1] https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes
Pull Request resolved: facebook#11118
Reviewed By: cbi42
Differential Revision: D42711356
Pulled By: ajkr
fbshipit-source-id: 5ea257b85b7017f40fd8fdbce965336da95c55b2
wez
added a commit
to KumoCorp/kumomta
that referenced
this pull request
Jun 8, 2023
cronokirby
added a commit
to penumbra-zone/penumbra
that referenced
this pull request
Jul 12, 2023
Depending on the C++ toolchain used by the underlying system, builds of rocksdb might fail because of an issue documented in: facebook/rocksdb#11118 (In short, the code relied on headers importing other headers, rather than what the standard guarantees headers to export; thus code may not compiler on all toolchains). Version 0.21 of the crate fixes this issue, by relying on a later version of the underlying rocksdb library. For the rust crate, this issue showed up in: rust-rocksdb/rust-rocksdb#772 On Linux/Manjaro I ran into this issue as well, but I expect that other people following along with the docs might run into it as well, so probably worth updating, unless there's some issue with doing so.
redshiftzero
pushed a commit
to penumbra-zone/penumbra
that referenced
this pull request
Jul 12, 2023
Depending on the C++ toolchain used by the underlying system, builds of rocksdb might fail because of an issue documented in: facebook/rocksdb#11118 (In short, the code relied on headers importing other headers, rather than what the standard guarantees headers to export; thus code may not compiler on all toolchains). Version 0.21 of the crate fixes this issue, by relying on a later version of the underlying rocksdb library. For the rust crate, this issue showed up in: rust-rocksdb/rust-rocksdb#772 On Linux/Manjaro I ran into this issue as well, but I expect that other people following along with the docs might run into it as well, so probably worth updating, unless there's some issue with doing so.
mgfritch
pushed a commit
to SUSE/ceph
that referenced
this pull request
Aug 30, 2023
This applies three patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 - A tweak to db/compaction/compaction_iteration_stats.h, lifted from https://src.fedoraproject.org/rpms/ceph/blob/rawhide/f/0024-gcc-13.patch Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
mgfritch
pushed a commit
to SUSE/ceph
that referenced
this pull request
Aug 30, 2023
This applies three patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 - A tweak to db/compaction/compaction_iteration_stats.h, lifted from https://src.fedoraproject.org/rpms/ceph/blob/rawhide/f/0024-gcc-13.patch Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
stephans
pushed a commit
to stephans/rocksdb
that referenced
this pull request
Dec 7, 2023
Summary:
Like other versions before, gcc 13 moved some includes around and as a result <cstdint> is no longer transitively included [1]. Explicitly include it for uint{32,64}_t.
[1] https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes
Pull Request resolved: facebook#11118
Reviewed By: cbi42
Differential Revision: D42711356
Pulled By: ajkr
fbshipit-source-id: 5ea257b85b7017f40fd8fdbce965336da95c55b2
kupietz
added a commit
to kupietz/rocksdb
that referenced
this pull request
Dec 21, 2023
ovr
pushed a commit
to cube-js/rocksdb
that referenced
this pull request
Jan 14, 2024
Summary:
Like other versions before, gcc 13 moved some includes around and as a result <cstdint> is no longer transitively included [1]. Explicitly include it for uint{32,64}_t.
[1] https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes
Pull Request resolved: facebook#11118
Reviewed By: cbi42
Differential Revision: D42711356
Pulled By: ajkr
fbshipit-source-id: 5ea257b85b7017f40fd8fdbce965336da95c55b2
mgfritch
pushed a commit
to SUSE/ceph
that referenced
this pull request
Mar 6, 2024
This applies three patches to the embedded rocksdb source: - facebook/rocksdb#11118 - facebook/rocksdb#11137 - A tweak to db/compaction/compaction_iteration_stats.h, lifted from https://src.fedoraproject.org/rpms/ceph/blob/rawhide/f/0024-gcc-13.patch Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>
adzfolc
pushed a commit
to ctripcorp/rocksdb
that referenced
this pull request
Nov 6, 2024
Summary:
Like other versions before, gcc 13 moved some includes around and as a result <cstdint> is no longer transitively included [1]. Explicitly include it for uint{32,64}_t.
[1] https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes
Pull Request resolved: facebook#11118
Reviewed By: cbi42
Differential Revision: D42711356
Pulled By: ajkr
fbshipit-source-id: 5ea257b85b7017f40fd8fdbce965336da95c55b2
adzfolc
pushed a commit
to ctripcorp/rocksdb
that referenced
this pull request
Nov 6, 2024
Summary:
Like other versions before, gcc 13 moved some includes around and as a result <cstdint> is no longer transitively included [1]. Explicitly include it for uint{32,64}_t.
[1] https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes
Pull Request resolved: facebook#11118
Reviewed By: cbi42
Differential Revision: D42711356
Pulled By: ajkr
fbshipit-source-id: 5ea257b85b7017f40fd8fdbce965336da95c55b2
adzfolc
pushed a commit
to ctripcorp/rocksdb
that referenced
this pull request
Nov 7, 2024
Summary:
Like other versions before, gcc 13 moved some includes around and as a result <cstdint> is no longer transitively included [1]. Explicitly include it for uint{32,64}_t.
[1] https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes
Pull Request resolved: facebook#11118
Reviewed By: cbi42
Differential Revision: D42711356
Pulled By: ajkr
fbshipit-source-id: 5ea257b85b7017f40fd8fdbce965336da95c55b2
patpatbear
pushed a commit
to ctripcorp/rocksdb
that referenced
this pull request
Nov 8, 2024
Summary:
Like other versions before, gcc 13 moved some includes around and as a result <cstdint> is no longer transitively included [1]. Explicitly include it for uint{32,64}_t.
[1] https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes
Pull Request resolved: facebook#11118
Reviewed By: cbi42
Differential Revision: D42711356
Pulled By: ajkr
fbshipit-source-id: 5ea257b85b7017f40fd8fdbce965336da95c55b2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like other versions before, gcc 13 moved some includes around and as a result is no longer transitively included [1]. Explicitly include it for uint{32,64}_t.
[1] https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes