-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(phases): mark remote HEAD and all ancestors as public #600
Comments
I skimmed phases.py to see if anything stood out to me as a way to fix this bug, but didn't see anything. Would appreciate some direction on where to start looking |
@vegerot thanks for reporting the issue. You can considering add the remote name in repo config
You might need to add write logic for the repo config. |
Summary: c8b66c6 added support for cloning the remote git repo's HEAD (in this case `develop`), instead of main/master by default. However, this doesn't mark `remote/develop` and its ancestors as public commits. This commit will also set remote git repo's HEAD as a public commit Closes facebook#600 Pull Request resolved: facebook#607 Test Plan: - Added test `test-git-clone-sets-publicheads.t`
Summary: c8b66c6 added support for cloning the remote git repo's HEAD (in this case `develop`), instead of main/master by default. However, this doesn't mark `remote/develop` and its ancestors as public commits. This commit will also set remote git repo's HEAD as a public commit Closes facebook#600 Pull Request resolved: facebook#607 Test Plan: - Added test `test-git-clone-sets-publicheads.t`
@vegerot thanks for fixing it, commented in the PR |
Summary: c8b66c6 added support for cloning the remote git repo's HEAD (in this case `develop`), instead of main/master by default. However, this doesn't mark `remote/develop` and its ancestors as public commits. This commit will also set remote git repo's HEAD as a public commit Closes facebook#600 Pull Request resolved: facebook#607 Test Plan: - Added test `test-git-clone-sets-publicheads.t`
Summary: c8b66c6 added support for cloning the remote git repo's HEAD (in this case `develop`), instead of main/master by default. However, this doesn't mark `remote/develop` and its ancestors as public commits. This commit will also set remote git repo's HEAD as a public commit Closes facebook#600 Pull Request resolved: facebook#607 Test Plan: - Added test `test-git-clone-sets-publicheads.t`
Summary: c8b66c6 added support for cloning the remote git repo's HEAD (in this case `develop`), instead of main/master by default. However, this doesn't mark `remote/develop` and its ancestors as public commits. This commit will also set remote git repo's HEAD as a public commit Closes facebook#600 Pull Request resolved: facebook#607 Test Plan: - Added test `test-git-clone-sets-publicheads.t`
Summary: c8b66c6 added support for cloning the remote git repo's HEAD (in this case `develop`), instead of main/master by default. However, this doesn't mark `remote/develop` and its ancestors as public commits. This commit will also set remote git repo's HEAD as a public commit Closes facebook#600 Pull Request resolved: facebook#607 Test Plan: - Added test `test-git-clone-sets-publicheads.t`
steps to reproduce
sl clone
a git repo with many commits and no branches named main or master (e.g. a repo with one branch nameddevelop
)sl sl
expected: should show one commit that is the public HEAD
actual:
note: this bug is also visible in the commit message for c8b66c6
Explanation
c8b66c6 added support for cloning the remote git repo's HEAD (in this case
develop
), instead of main/master by default.However, this doesn't mark
remote/develop
and its ancestors as public commits.Suggested fix
When cloning a repository, mark the cloned head as public
The text was updated successfully, but these errors were encountered: