fix mononoke build #769
fix mononoke build #769
Conversation
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
It looks like our internal build is unfortunately failing to build. The compiler is sending us to rust-lang/rust#96024 which appears to still be open. Can you re-send this PR while keeping the feature? |
Makes usage of anyhow::Error::backtrace() conditional on fbcode_build. This is necessary because the cargo build of anyhow disables its backtrace features when using RUSTC_BOOTSTRAP=1 For oss cargo build to work on current rustc stable 1.73+ I hid the #![feature(provide_any)] usage by making it condition on fbcode_build. Test plan: local build with `./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. mononoke` github CI, done by regenerating the mononoke github actions with: `./build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --free-up-disk --src-dir=. --output-dir=.github/workflows --job-name="Mononoke " --job-file-prefix=mononoke_ mononoke` Before, broken After, works
|
@ahornby has updated the pull request. You must reimport the pull request before landing. |
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
done, added in cfg_attr usage to keep it off in oss build but on otherwise |
|
This pull request has been merged in 41e6e88. |
fix mononoke build
Makes usage of anyhow::Error::backtrace() conditional on fbcode_build. This is necessary because the cargo build of anyhow disables its backtrace features when using RUSTC_BOOTSTRAP=1
For oss cargo build to work on current rustc stable 1.73+ I hid the #![feature(provide_any)] usage by making it condition on fbcode_build.
Test plan:
local build with
./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. mononokegithub CI, done by regenerating the mononoke github actions with:
./build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --free-up-disk --src-dir=. --output-dir=.github/workflows --job-name="Mononoke " --job-file-prefix=mononoke_ mononokeBefore, broken
After, works