perf(github): improve gh start time by skipping lookup table generation
#961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion
Summary:
This change improves the start time of gh by skipping the generation of the
lookup table in tcell, a dependency of gh. This is done by setting the
`TCELL_MINIMIZE` environment variable when calling `gh`.
Here is a benchmark for a frequent command we run
```sh
$ hyperfine -w2 \
'gh auth status --hostname github.com' \
'TCELL_MINIMIZE=1 gh auth status --hostname github.com'
Benchmark 1: gh auth status --hostname github.com
Time (mean ± σ): 406.5 ms ± 13.4 ms [User: 63.9 ms, System: 25.6 ms]
Range (min … max): 389.0 ms … 430.3 ms 10 runs
Benchmark 2: TCELL_MINIMIZE=1 gh auth status --hostname github.com
Time (mean ± σ): 380.6 ms ± 10.9 ms [User: 42.8 ms, System: 27.3 ms]
Range (min … max): 364.1 ms … 404.2 ms 10 runs
Summary
TCELL_MINIMIZE=1 gh auth status --hostname github.com ran
1.07 ± 0.05 times faster than gh auth status --hostname github.com
```
I tried measuring the impact of this change on `sl pr list` but it's too noisy.
Are there any better examples?
```sh
$ hyperfine -w3 'CHGDISABLE=1 sl pr list' 'CHGDISABLE=1 ./sl pr list'
Benchmark 1: CHGDISABLE=1 sl pr list
Time (mean ± σ): 772.0 ms ± 193.8 ms [User: 227.0 ms, System: 55.2 ms]
Range (min … max): 664.2 ms … 1313.6 ms 10 runs
Benchmark 2: CHGDISABLE=1 ./sl pr list
Time (mean ± σ): 741.8 ms ± 29.5 ms [User: 242.1 ms, System: 68.9 ms]
Range (min … max): 689.8 ms … 778.1 ms 10 runs
Summary
CHGDISABLE=1 ./sl pr list ran
1.04 ± 0.26 times faster than CHGDISABLE=1 sl pr list
```
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request has been merged in c669d66. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change improves the start time of gh by skipping the generation of the
lookup table in tcell, a dependency of gh. This is done by setting the
TCELL_MINIMIZEenvironment variable when callinggh.Here is a benchmark for a frequent command we run
I tried measuring the impact of this change on
sl pr listbut it's too noisy.Are there any better examples?