Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for bit operations #5

Closed
ndmitchell opened this issue Mar 1, 2021 · 1 comment
Closed

No support for bit operations #5

ndmitchell opened this issue Mar 1, 2021 · 1 comment
Labels
good first issue Good for newcomers spec Violations from the Starlark spec

Comments

@ndmitchell
Copy link
Contributor

ndmitchell commented Mar 1, 2021

From the spec:

Bitwise operations:
  int ^ int                    # bitwise XOR
  int & int                    # bitwise AND
  int | int                    # bitwise OR
  int << int                   # bitwise left shift
  int >> int                   # bitwise right shift (arithmetic)

Plus:

~ number        unary bitwise inversion (int)

We don't support these operations.

@ndmitchell ndmitchell added good first issue Good for newcomers spec Violations from the Starlark spec labels Mar 1, 2021
facebook-github-bot pushed a commit that referenced this issue Mar 4, 2021
Summary:
Add bitwise operators (bitwise and, or, xor, left shift, right shift, and bitwise negation) to Starlark

#5

Reviewed By: ndmitchell

Differential Revision: D26800090

fbshipit-source-id: 4f41af18492bcbfab56c7167014cd01bd72245cd
@ndmitchell
Copy link
Contributor Author

This landed, so one spec violation down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers spec Violations from the Starlark spec
Projects
None yet
Development

No branches or pull requests

1 participant