Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix priority of three physical border properties. #607

Closed
wants to merge 2 commits into from
Closed

Fix priority of three physical border properties. #607

wants to merge 2 commits into from

Conversation

etlovett
Copy link
Contributor

@etlovett etlovett commented Jun 18, 2024 •
edited
Loading

What changed / motivation ?

I was inspecting this file and noticed that these three properties appeared to be stored in the wrong priority set. The other physical longhands (e.g. border-bottom-color and border-left-width) are stored in longHandPhysical.

Linked PR/Issues

None

Additional Context

None

Pre-flight checklist

@facebook-github-bot
Copy link

Hi @etlovett!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

nmn
nmn approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@nmn nmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please accept the CLA so I can merge!

@etlovett
Copy link
Contributor Author

Please accept the CLA so I can merge!

Yep, will do! I'm working to figure out what the right channels are at my employer for this approval.

@etlovett
Copy link
Contributor Author

@nmn FYI I have now signed the CLA. Feel free to merge!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 29, 2024
@nmn
Copy link
Contributor

nmn commented Jun 30, 2024

Merged in 33d5e0a

@nmn nmn closed this Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmn nmn nmn approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etlovett @facebook-github-bot @nmn