Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stop polyfilling logical text-align #632

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

nmn
Copy link
Contributor

@nmn nmn commented Jul 6, 2024

Fixes #627

The styleResolution: 'legacy-expand-shorthands' configuration also converts logical properties to physical properties for supporting very old browsers.

Turns out that logical text-align has been supported in even the oldest browsers, so deleting the code that converts those logical values to physical ones.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 6, 2024
Copy link

github-actions bot commented Jul 6, 2024

compressed-size: runtime library

Size change: 0.00 kB
Total size: 2.52 kB

View unchanged
Filename: gzip (minify) kB size kB change % change
./packages/stylex/lib/stylex.js 1.04 (3.22) 0.00 (0.00) 0.0% (0.0%)
./packages/stylex/lib/StyleXSheet.js 1.48 (3.75) 0.00 (0.00) 0.0% (0.0%)

Copy link

github-actions bot commented Jul 6, 2024

compressed-size: e2e bundles

Size change: -0.05 kB
Total size: 1125.68 kB

Filename: gzip (minify) kB size kB change % change
./apps/rollup-example/.build/stylex.css 123.19 (774.43) -0.05 (-0.44) -0.0% (-0.1%) 🟢
View unchanged
Filename: gzip (minify) kB size kB change % change
./apps/rollup-example/.build/bundle.js 1002.49 (10185.35) 0.00 (0.00) 0.0% (0.0%)

@necolas necolas merged commit f1e494d into main Jul 8, 2024
9 checks passed
@nmn nmn deleted the fix/logical-text-align branch July 9, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop transforming textAlign:start/end
3 participants