Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: autofix for horizontal/vertical padding/margins #690

Merged
merged 4 commits into from
Sep 21, 2024

Conversation

mellyeliu
Copy link
Member

@mellyeliu mellyeliu commented Sep 17, 2024

What changed / motivation ?

TSIA

Testing

Added tests to check proper translations:

  • marginHorizontal -> marginInline
  • marginVertical -> marginBlock
  • paddingHorizontal -> paddingInline
  • paddingVertical -> paddingBlock

Screenshots, Tests, Anything Else

Pre-flight checklist

@mellyeliu mellyeliu requested a review from nmn September 17, 2024 14:42
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 17, 2024
Copy link

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

@stylexjs/scripts@0.7.5 size:compare
./size-compare.js /tmp/tmp.1Uw2BY8f2m /tmp/tmp.WSyTMAXiO7

Results Base Patch Ratio
stylex/lib/stylex.js
· compressed 899 899 1.00
· minified 3,223 3,223 1.00
stylex/lib/StyleXSheet.js
· compressed 1,266 1,266 1.00
· minified 3,776 3,776 1.00
rollup-example/.build/bundle.js
· compressed 563,563 563,563 1.00
· minified 10,185,348 10,185,348 1.00
rollup-example/.build/stylex.css
· compressed 100,211 100,211 1.00
· minified 759,868 759,868 1.00

@mellyeliu mellyeliu merged commit deaa7ce into main Sep 21, 2024
8 checks passed
@nmn nmn deleted the logical-properties-fix branch September 24, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants