fix: Don't add units number values used for variables #694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #689
For convenience and to match the behaviour of React Native, StyleX allows the usage of numbers as values and tries to automatically add units where they make sense.
The issue, however, is that for any unknown value StyleX assumes it to be a length and adds
px
unit by default. While we should probably revisit that behaviour itself, for now, this PR adds a special case for CSS variables and leaves numbers used as values for CSS variables keys as is.