Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [CLI] Handle errors while deleting files gracefully #695

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

nmn
Copy link
Contributor

@nmn nmn commented Sep 24, 2024

A previous PR #680 had mysterious CI errors. This is a second attempt at the same change.

@nmn nmn requested a review from Jta26 September 24, 2024 00:56
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 24, 2024
Copy link

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

@stylexjs/scripts@0.7.5 size:compare
./size-compare.js /tmp/tmp.YaSpjsr1CS /tmp/tmp.q7PWF2w7BT

Results Base Patch Ratio
stylex/lib/stylex.js
· compressed 899 899 1.00
· minified 3,223 3,223 1.00
stylex/lib/StyleXSheet.js
· compressed 1,266 1,266 1.00
· minified 3,776 3,776 1.00
rollup-example/.build/bundle.js
· compressed 563,563 563,563 1.00
· minified 10,185,348 10,185,348 1.00
rollup-example/.build/stylex.css
· compressed 100,211 100,211 1.00
· minified 759,868 759,868 1.00

@nmn nmn merged commit 2b77aad into main Sep 24, 2024
8 checks passed
@nmn nmn deleted the fix/cli-rm-file branch September 24, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants