Skip to content

Commit

Permalink
travis: speculative diff to reduce travis noise
Browse files Browse the repository at this point in the history
Looks like we need to wait longer for the since-term test to settle,
so let's assert the file list before we sample our first clock.

Stop skipping the kFSEventStreamEventFlagRootChanged case; this
does actually work.
  • Loading branch information
wez committed Mar 29, 2015
1 parent 44ce364 commit 34bede7
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 8 deletions.
7 changes: 0 additions & 7 deletions tests/integration/remove.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@ function testRemove() {
if (PHP_OS == 'Linux' && getenv('TRAVIS')) {
$this->assertSkipped('openvz and inotify unlinks == bad time');
}
if (PHP_OS == 'Darwin') {
$this->assertSkipped(
"fseventsd doesn't signal kFSEventStreamEventFlagRootChanged");
}
$watches = $this->waitForWatchman(
array('watch-list'),
function ($list) use ($root) {
Expand All @@ -64,6 +60,3 @@ function ($list) use ($root) {
);
}
}



5 changes: 5 additions & 0 deletions tests/integration/since-term.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ function testSinceExpr() {
touch("$root/subdir/bar.txt");

$this->watch($root);
$this->assertFileList($root, array(
'foo.c',
'subdir',
'subdir/bar.txt'
));

$foo_data = $this->watchmanCommand('find', $root, 'foo.c');
$first_clock = $foo_data['clock'];
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/trigger-chdir.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function testChdir() {

$this->waitFor(
function () use ($env, $root) {
$envdata = file_get_contents($env);
$envdata = @file_get_contents($env);
return preg_match(",PWD=$root/sub,", $envdata) == 1;
},
10,
Expand Down

0 comments on commit 34bede7

Please sign in to comment.