Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are failing on firefox 31.3.0 #25

Closed
m1el opened this issue Jan 30, 2015 · 4 comments
Closed

Tests are failing on firefox 31.3.0 #25

m1el opened this issue Jan 30, 2015 · 4 comments

Comments

@m1el
Copy link

m1el commented Jan 30, 2015

To reproduce: open RunLayoutTests.html in firefox.

all tests are failing in firefox

@vjeux
Copy link
Contributor

vjeux commented Jan 30, 2015

Yeah, I tried to get it working on Firefox but couldn't get it to work 100% of the time so I gave up. Pull requests to fix it are more than welcome

@1genius
Copy link

1genius commented Feb 4, 2015

What is the problem with firefox? I would like to try and fix the bug.

@vjeux
Copy link
Contributor

vjeux commented Feb 4, 2015

If I remember correctly, it had to do with the creation of the iframe and setting css. I couldn't get the timings right.

https://github.com/facebook/css-layout/blob/master/src/Layout-test-utils.js#L52-L83

ryanseddon added a commit to ryanseddon/css-layout that referenced this issue Feb 5, 2015
@vjeux vjeux closed this as completed in 1ad94fa Feb 5, 2015
vjeux added a commit that referenced this issue Feb 5, 2015
Fix firefox iframe timing issue in test runners, fixes #25
@1genius
Copy link

1genius commented Feb 9, 2015

Hi Christopher,

I’m writing because I need your help. I was looking at the java code for iframe. I would like very much to help you and other java developers on the Github site but my java is at the basic level. I got an A+ in the basic course. How do I get to your level? Your program in iframe uses function but I know that methods in java start with public static void or public static int. I would really appreciate your advice.

Thank you,
Ben

On Feb 4, 2015, at 11:21 AM, Christopher Chedeau notifications@github.com wrote:

If I remember correctly, it had to do with the creation of the iframe and setting css. I couldn't get the timings right.

https://github.com/facebook/css-layout/blob/master/src/Layout-test-utils.js#L52-L83 https://github.com/facebook/css-layout/blob/master/src/Layout-test-utils.js#L52-L83

Reply to this email directly or view it on GitHub #25 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants